cuboid::domain_t fix for std::vector constructor #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
HugoStrand
pushed a commit
to HugoStrand/triqs
that referenced
this pull request
Feb 6, 2018
Closed
jkarp314
pushed a commit
to jkarp314/triqs
that referenced
this pull request
Feb 24, 2021
hmenke
pushed a commit
to hmenke/triqs
that referenced
this pull request
Nov 8, 2023
* use autosummary for module reference, cleanup doc strings * bump up triqs version req to 3.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code previously couldn't be linked
tqa::indexmaps::cuboid::domain_t<1> d({10});because of the corresponding constructor from std::vector using
static constexpr rank == Rankintriqs/arrays/indexmaps/cuboid/domain.hpp. The constructor is defined inside the class definition, and so has the problem similar to the one, listed below.See http://stackoverflow.com/questions/8016780/undefined-reference-to-static-constexpr-char
It works, if one uses the name from the template declaration.