Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cuboid::domain_t fix for std::vector constructor #3

Closed
wants to merge 1 commit into from
Closed

cuboid::domain_t fix for std::vector constructor #3

wants to merge 1 commit into from

Conversation

aeantipov
Copy link
Contributor

This code previously couldn't be linked
tqa::indexmaps::cuboid::domain_t<1> d({10});
because of the corresponding constructor from std::vector using static constexpr rank == Rank in triqs/arrays/indexmaps/cuboid/domain.hpp. The constructor is defined inside the class definition, and so has the problem similar to the one, listed below.
See http://stackoverflow.com/questions/8016780/undefined-reference-to-static-constexpr-char
It works, if one uses the name from the template declaration.

@parcollet parcollet closed this in 4413c6a Sep 8, 2013
@Kh89 Kh89 mentioned this pull request Jan 22, 2014
HugoStrand pushed a commit to HugoStrand/triqs that referenced this pull request Feb 6, 2018
@cmtcl18 cmtcl18 mentioned this pull request Aug 22, 2019
jkarp314 pushed a commit to jkarp314/triqs that referenced this pull request Feb 24, 2021
hmenke pushed a commit to hmenke/triqs that referenced this pull request Nov 8, 2023
* use autosummary for module reference, cleanup doc strings

* bump up triqs version req to 3.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant